Fixes #27353 - use vmware network id instead of name #6918
Conversation
|
Issues: #27353 |
| @@ -464,7 +464,7 @@ def parse_networks(args) | |||
| # Convert network id into name | |||
| net = dc_networks.detect { |n| [n.id, n.name].include?(interface['network']) } | |||
There was a problem hiding this comment.
Should this also be changed to first try all IDs and otherwise fall back to a name? I'm wondering if there's a case where the first network has the ID of a later network and you could end up with a mismatch.
There was a problem hiding this comment.
the network id should be always unique.
It could happen though in rare cases that you name your network in a manner of the vmware network id (i.e. network_4302) and it could end up selected. I left this for hammer as now if you have in some hammer commands a network name, it works, but it wouldn't now. But we can iterate twice. It will probably be better, to avoid the weird naming usecases...
ezr-ondrej
force-pushed
the
vmware_use_id
branch
from
d269d08
to
a3052d1
Compare
ezr-ondrej
force-pushed
the
vmware_use_id
branch
from
a3052d1
to
9c74df4
Compare
|
Updated according to the suggestion (first looking by id, than by name). |
There was a problem hiding this comment.
makes sense to me but my vmware knowledge is very limited - would feel safer to merge if @timogoebel or @chris1984 can also ack.
There was a problem hiding this comment.
Looks good ACK. Only question I had is should we remove this comment since we are using ID now? https://github.com/theforeman/foreman/pull/6918/files#diff-4443c0de1e4e867a30d3c878b9cb64e9R463
ezr-ondrej
force-pushed
the
vmware_use_id
branch
from
9c74df4
to
4d81bae
Compare
ezr-ondrej
force-pushed
the
vmware_use_id
branch
from
4d81bae
to
6385030
Compare
Removed the comment. Thanks @chris1984. |
Use network id, not it's name. As if the name is ambigous, fog-vsphere uses the first one, which can be one we are unable to provision on.
Fog supports it from version 3.1.0, which is already in our packaging.